Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build std for sparc64-unknown-linux-gnu #39647

Merged
merged 2 commits into from
Feb 9, 2017
Merged

build std for sparc64-unknown-linux-gnu #39647

merged 2 commits into from
Feb 9, 2017

Conversation

japaric
Copy link
Member

@japaric japaric commented Feb 8, 2017

r? @alexcrichton

panicking / unwinding is broken (#39646) but with std available at least people
will be able to debug that issue on real hardware

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

Can you also update src/tools/build-manifest to include this target? Otherwise looks great!

@japaric
Copy link
Member Author

japaric commented Feb 8, 2017

@alexcrichton Like so?

@alexcrichton
Copy link
Member

I believe so!

@bors: r+

@bors
Copy link
Contributor

bors commented Feb 8, 2017

📌 Commit 4997178 has been approved by alexcrichton

@codyps codyps mentioned this pull request Feb 8, 2017
Closed
@frewsxcv frewsxcv mentioned this pull request Feb 9, 2017
Merged
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 9, 2017
@frewsxcv
Rollup merge of rust-lang#39647 - japaric:sparc, r=alexcrichton
116bdac 
build std for sparc64-unknown-linux-gnu

r? @alexcrichton

panicking / unwinding is broken (rust-lang#39646) but with std available at least people
will be able to debug that issue on real hardware
bors added a commit that referenced this pull request Feb 9, 2017
@bors
Auto merge of #39686 - frewsxcv:rollup, r=frewsxcv
e7fc53b 
Rollup of 5 pull requests

- Successful merges: #39595, #39601, #39602, #39615, #39647
- Failed merges:
@bors bors merged commit 4997178 into rust-lang:master Feb 9, 2017
@sunnystormy
Copy link

sunnystormy commented Feb 16, 2017 •
edited
Loading

Don't mean to necro this, but if I were to use the Nightly version of Rust, would I have access to this feature? Also, how soon will this make it over to Stable?

Thanks!

@alexcrichton
Copy link
Member

@sunnystormy you can access this right now via:

rustup target add sparc64-unknown-linux-gnu --toolchain nightly

@sunnystormy
Copy link

@alexcrichton Thank you, sir! Works like a charm. 😸

@mihaipopescu mihaipopescu mentioned this pull request Jul 11, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@japaric @rust-highfive @alexcrichton @bors @sunnystormy